Skip to content

Conversation

@gramalingam
Copy link
Collaborator

This copilot-suggested fix enabled converting a recent onnx model to onnxscript.

Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.09%. Comparing base (70abdd9) to head (c494888).
⚠️ Report is 12 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
onnxscript/backend/onnx_export.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
- Coverage   70.10%   70.09%   -0.01%     
==========================================
  Files         228      228              
  Lines       27394    27385       -9     
  Branches     2781     2783       +2     
==========================================
- Hits        19204    19195       -9     
+ Misses       7234     7231       -3     
- Partials      956      959       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Updated string decoding logic and attribute value check.
@justinchuby justinchuby enabled auto-merge (squash) January 8, 2026 16:34
@justinchuby justinchuby merged commit b6e9878 into main Jan 8, 2026
31 of 33 checks passed
@justinchuby justinchuby deleted the rama/unicode branch January 8, 2026 16:34
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants