Skip to content

Conversation

@ipcjs
Copy link
Contributor

@ipcjs ipcjs commented Oct 20, 2025

Some PR timeline arrays can contain null values, which causes downstream parsing errors
Ignoring null entries fixes the parsing error.

for example: TranscodeGroup/docker#23.
截屏2025-10-20 17 56 26

@ipcjs
Copy link
Contributor Author

ipcjs commented Oct 20, 2025

@microsoft-github-policy-service agree

@ipcjs ipcjs marked this pull request as ready for review October 20, 2025 09:57
@alexr00
Copy link
Member

alexr00 commented Oct 20, 2025

@ipcjs that's where the __typename error was coming from? Nice find. Based on the query, that shouldn't be possible:

https://github.com/ipcjs/vscode-pull-request-github/blob/688855c6807e1c505ea2b81585e69360cb3a9781/src/github/queriesShared.gql#L296-L319

GitHub must have changed something. How'd you figure this out?

@ipcjs
Copy link
Contributor Author

ipcjs commented Oct 20, 2025

This PR(TranscodeGroup/docker#23) was added to a private Project, maybe that's related?

截屏2025-10-20 18 20 24

@alexr00 alexr00 enabled auto-merge (squash) October 20, 2025 11:50
@alexr00
Copy link
Member

alexr00 commented Oct 20, 2025

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@alexr00 alexr00 merged commit 1f79dd6 into microsoft:main Oct 20, 2025
3 checks passed
alexr00 added a commit that referenced this pull request Oct 30, 2025
alexr00 added a commit that referenced this pull request Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants