Fix dismiss notification functionality in PR view #8241
+38
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PR Node Notification Refresh Issue
The problem: When notifications change, PR nodes don't refresh their tree items to update the context value, causing the "dismiss notification" option to not appear in the context menu until a manual refresh.
Solution:
This PR fixes the bug by adding event listeners in PRNode to monitor notification changes from both NotificationsManager (regular notifications) and PrsTreeModel (Copilot notifications). When a notification affecting a specific PR changes, the node refreshes itself to update its tree item with the correct context value, which controls the visibility of the dismiss notification menu item.
Changes Made:
registerNotificationChanges()method to PRNode that listens to both regular and Copilot notification changes:notificationsuffix is added/removed from the context value dynamically, which controls the visibility of the "dismiss notification" menu itemTesting:
The changes ensure that the "dismiss notification" context menu option appears/disappears correctly without requiring a manual refresh of the PR view.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.