added imecos environment #809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
InDieTasten
reviewed
Mar 2, 2025
Comment on lines
+47
to
+49
| -EnabledForDeployment -EnabledForTemplateDeployment -EnablePurgeProtection:$EnablePurgeProtection | ||
| -Sku Standard ` | ||
| -ErrorAction Stop |
There was a problem hiding this comment.
Suggested change
| -EnabledForDeployment -EnabledForTemplateDeployment -EnablePurgeProtection:$EnablePurgeProtection | |
| -Sku Standard ` | |
| -ErrorAction Stop | |
| -EnabledForDeployment -EnabledForTemplateDeployment -EnablePurgeProtection:$EnablePurgeProtection ` | |
| -Sku Standard ` | |
| -ErrorAction Stop |
InDieTasten
suggested changes
Mar 2, 2025
InDieTasten
left a comment
InDieTasten
left a comment
There was a problem hiding this comment.
Are you aware that you are creating a Pull Request to the upstream project that you forked from? I feel like your workflows don't really belong to the official sample repo, especially since you are not only doing build validation but are also signing into Azure with a secret that will not be defined on this repo.
If you drop the workflows and just update the broken ps1 script, I believe your change could be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
his PR removes the deprecated -EnableRbacAuthorization flag from the Key Vault creation script to ensure compatibility with newer versions of Azure PowerShell.