Skip to content

PHP 8.4 compatibility #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baywet merged 2 commits into from
Mar 28, 2025
Merged

PHP 8.4 compatibility #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d73fe5
PHP 8.4 compatibility
hubipe Mar 28, 2025
915e2f4
Added PHP version 8.4 to the pr-validation.yml
hubipe Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['7.4', '8.1', '8.2', '8.3']
php-versions: ['7.4', '8.1', '8.2', '8.3', '8.4']
steps:
- uses: actions/checkout@v4.2.2
- name: Setup PHP
Expand Down
2 changes: 1 addition & 1 deletion src/GraphClientFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ public static function createWithMiddleware(HandlerStack $handlerStack): Client
* @param callable|null $handler final handler
* @return HandlerStack
*/
public static function getDefaultHandlerStack(callable $handler = null): HandlerStack
public static function getDefaultHandlerStack(?callable $handler = null): HandlerStack
{
$handlerStack = parent::getDefaultHandlerStack();
if ($handler) {
Expand Down
2 changes: 1 addition & 1 deletion src/Requests/BaseBatchRequestBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class BaseBatchRequestBuilder
* @param RequestAdapter $requestAdapter
* @param array<string, array{class-string<T>, string}>|null $errorMappings
*/
public function __construct(RequestAdapter $requestAdapter, array $errorMappings = null)
public function __construct(RequestAdapter $requestAdapter, ?array $errorMappings = null)
{
$this->requestAdapter = $requestAdapter;
$this->errorMappings = $errorMappings;
Expand Down