Skip to content

Fix failing static type checks #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ndiritu merged 26 commits into from
Dec 18, 2024
Merged

Fix failing static type checks #773

Ndiritu merged 26 commits into from
Dec 18, 2024

Conversation

@Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Dec 13, 2024

This PR:

  • Bumps Kiota dependencies to latest versions
  • Fixes mypy failures
  • Ignores failures that have exposed bugs

@Ndiritu Ndiritu self-assigned this Dec 13, 2024
@Ndiritu Ndiritu force-pushed the fix/failing-static-checks branch 2 times, most recently from dd7ce66 to f1bf6af Compare December 16, 2024 09:32
@Ndiritu Ndiritu changed the title Fixes type hints and failing static type checks Fix failing static type checks Dec 16, 2024
@Ndiritu Ndiritu marked this pull request as ready for review December 16, 2024 09:34
@Ndiritu Ndiritu requested a review from a team as a code owner December 16, 2024 09:34
Ndiritu added 24 commits December 16, 2024 12:34
@Ndiritu
chore: bump kiota dependencies
2a2b2d2
@Ndiritu
enable static checks for missing imports
7b0c51b
@Ndiritu
Expose error mappings in page iterator and ignore errors due to undef…
33bdf40 
…ined behaviour
@Ndiritu
Resolve large file upload type issues
0621804
@Ndiritu
Fix typing issue in auth provider
d678554
@Ndiritu
Resolve errors in graph client factory
b9b704f
@Ndiritu
Fix batch request item type hint issues
9d48700
@Ndiritu
Fix batch request content issues
3c1d998
@Ndiritu
fix batch response item issues
2e77ff7
@Ndiritu
Fix batch response content type issues
ec2cc7e
@Ndiritu
fix batch response content collection
5b0e0e7
@Ndiritu
undo changes to batch request content remove()
210c174
@Ndiritu
fix issues in batch request content collection
d83c1dd
@Ndiritu
fix: Fixes type hints and failing mypy checks
85e8935
@Ndiritu
Undo breaking type changes in LFU and fix errors
e861019
@Ndiritu
clean up page iterator fixes
f3632a9
@Ndiritu
fix formatting issues
92efc9c
@Ndiritu
Fix page iterator type var
e1c575f
@Ndiritu
Fix pylint errors
9800f11
@Ndiritu
Fix Sonarcloud issues
defda71
@Ndiritu
Mark StreamInterface type as deprecated
68e5263 
StreamInterface is a PHP type that abstracts around built-in byte streams. BytesIO serves this purpose in Python
making this type unnecessary
@Ndiritu
Add missing pytest asyncio plugin causing pytest failure
3b46699
@Ndiritu
Fix formatting
1d0eacc
@Ndiritu
import deprecated package and its type stubs
4cfef9d
@Ndiritu Ndiritu force-pushed the fix/failing-static-checks branch from f1bf6af to 40b35dc Compare December 16, 2024 09:34
@Ndiritu Ndiritu mentioned this pull request Dec 16, 2024
Closed
@Ndiritu Ndiritu marked this pull request as draft December 16, 2024 10:02
@Ndiritu Ndiritu marked this pull request as ready for review December 16, 2024 10:17
baywet
baywet reviewed Dec 16, 2024
View reviewed changes
@baywet baywet requested a review from andrueastman December 16, 2024 14:05
andrueastman
andrueastman reviewed Dec 17, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@baywet baywet mentioned this pull request Dec 17, 2024
Merged
@baywet baywet mentioned this pull request Dec 17, 2024
Merged
@Ndiritu Ndiritu merged commit 8e20a51 into main Dec 18, 2024
14 checks passed
@Ndiritu Ndiritu deleted the fix/failing-static-checks branch December 18, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet baywet baywet approved these changes

+1 more reviewer

@andrueastman andrueastman andrueastman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Ndiritu Ndiritu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ndiritu @andrueastman @baywet