Fix add_batch_request_item #848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2025 10:49
baywet
requested changes
Mar 11, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Can you add some unit tests to prevent future regressions please?
Contributor
Author
|
tests added @baywet thanks! |
|
baywet
approved these changes
Mar 24, 2025
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
Thank you for making the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
the same batch was getting appended to the batches everytime a BatchRequestItem was added to a collection, so in sequence adding requests 1, 2 and 3, the batches would look like:
[[1]],
[[1,2],[1,2]]
[[1,2,3],[1,2,3],[1,2,3]]
etc