Skip to content

Conversation

@andypost
Copy link
Contributor

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.03%. Comparing base (924553d) to head (2654cdd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #185   +/-   ##
=========================================
  Coverage     98.03%   98.03%           
- Complexity      129      130    +1     
=========================================
  Files             1        1           
  Lines           305      306    +1     
=========================================
+ Hits            299      300    +1     
  Misses            6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 requested a review from Copilot August 13, 2025 03:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the deprecated usage of Reflection*::setAccessible() method to maintain compatibility with PHP 8.5, where this method has been deprecated. The change ensures the code continues to work across different PHP versions by conditionally calling setAccessible() only for PHP versions below 8.1.

  • Updates reflection property access to handle deprecated setAccessible() method
  • Adds version check to conditionally call setAccessible() for older PHP versions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@andypost
Copy link
Contributor Author

Generally speaking Copilot is right as since 8.1 the method is no-op but deprecation happened only in 8.5

@andypost
Copy link
Contributor Author

@stof please consider create a patch release as it's the last blocker for Drupal to support new PHP

@stof stof merged commit 225e673 into minkphp:master Aug 25, 2025
14 checks passed
@andypost andypost deleted the fix-get-accessible branch August 25, 2025 10:43
@andypost
Copy link
Contributor Author

andypost commented Oct 9, 2025

As no more regressions detected please create a new release to unblock Drupal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants