Implement type() method to use Syn.type. Fixed issue with key{press|d… #248
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own|up} not working on non-input elements.
aik099
reviewed
Oct 5, 2016
| * @param string $xpath | ||
| * @param string $text example: "Firstname\tLast\tmail@example.org\r" | ||
| * | ||
| */ |
Member
There was a problem hiding this comment.
This method can be useful, but needs to be added to:
- driver test suite
- driver interface
- at least to 2 other drivers
stof
reviewed
Oct 5, 2016
| $this->withSyn()->executeJsOnXpath($xpath, $script); | ||
| } | ||
|
|
||
| /** |
Member
There was a problem hiding this comment.
Mink drivers are abstractions. So the phpdoc of methods should absolutely not describe them by talking about their internal implementation.
and indeed, as @aik099 said, this method won't be accepted if it is not properly added to the Mink API (btw, people are not expected to use the driver directly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…own|up} not working on non-input elements.