Add detailed inference metrics tracking to mlx_whisper #1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive performance metrics tracking to MLX Whisper, enabling users to benchmark models, identify bottlenecks, and compare performance with other implementations.
Motivation
Currently, MLX Whisper provides transcription results but lacks visibility into performance characteristics. Users need to:
Changes Made
1. Enhanced
DecodingResultdataclass (mlx_whisper/decoding.py)num_inference_steps: int = 0field to track total decoder forward passes2. Modified
_main_loop()method (mlx_whisper/decoding.py)3. Added timing metrics (
mlx_whisper/transcribe.py)4. Added comprehensive output display (
mlx_whisper/transcribe.py)When
--verbose Trueis set, displays:Key Metrics Explained
Benefits
Testing
Tested on Apple Silicon (M3 Pro) with all available models:
All models achieve real-time performance (RTF < 1.0) on Apple Silicon.
Usage Examples
Basic usage (unchanged):
With detailed metrics:
Benchmark different models:
Files Changed
mlx_whisper/decoding.py- Added inference step trackingmlx_whisper/transcribe.py- Added timing metrics and benchmark outputPerformance Impact