Performed changes to listed warn() and logger.info #13530
+24
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/logger.debug as listed in POSSEE Conducted changes to non-logging messages using grep calls in POSSEE document, many were false positive. actual changes listed below.
salmanbl377
requested review from
adam2392,
agramfort,
dengemann,
drammock,
jasmainak,
larsoner,
mscheltienne and
sappelhoff
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
larsoner
reviewed
Dec 5, 2025
| return cov | ||
|
|
||
| logger.info(" Did not find the desired covariance matrix (kind = %d)", cov_kind) | ||
| logger.info(f" Did not find the desired covariance matrix (kind = {cov_kind})") |
Member
There was a problem hiding this comment.
This one I think was okay in main. These are logging.logger calls so delayed repr calls using % and *args can be useful
mne/_fiff/meas_info.py
Outdated
| # This shouldn't happen if we're up to date with the FIFF | ||
| # spec | ||
| warn(f"Discarding extra channel information kind {kind}") | ||
| warn("Discarding extra channel information kind %s" % (kind,)) |
Member
There was a problem hiding this comment.
@drammock I think these we probably don't want to change... our warn function is really a wrapper around warnings.warn which doesn't use *args or delayed % formatting
Member
There was a problem hiding this comment.
So we only want % for errors and for logger.info and logger.debug, but not for warn()?
Author
|
@larsoner i will push commits to fix style next |
for more information, see https://pre-commit.ci
reverted back to f-string per converesation
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/logger.debug as listed in POSSEE
Conducted changes to non-logging messages using
grep calls in POSSEE document, many were false
positive. actual changes listed below.
Reference issue (if any)
What does this implement/fix?
Additional information