Skip to content

feat: deprecated logger in client & add Logger in ClientOption #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CocaineCong wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: deprecated logger in client & add Logger in ClientOption #738

CocaineCong wants to merge 3 commits into from
+39 −10

Conversation

@CocaineCong
Copy link

@CocaineCong CocaineCong commented Dec 27, 2025

Fix #708

  1. deprecated logger in client
  2. add Logger in ClientOption
  3. add unit test for Logger

findleyr
findleyr reviewed Dec 31, 2025
View reviewed changes
Copy link
Contributor

@findleyr findleyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM following one minor nit.

@CocaineCong
Copy link
Author

CocaineCong commented Dec 31, 2025

LGTM following one minor nit.

I've already corrected it. PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findleyr findleyr findleyr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: add ClientOptions.Logger

2 participants

@CocaineCong @findleyr