Skip to content

Conversation

@He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Nov 18, 2025

Motivation and Context

This will help the implementations who want to handle everything theirself

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Signed-off-by: He-Pin <hepin1989@gmail.com>
.
Signed-off-by: He-Pin <hepin1989@gmail.com>
@Kehrlann
Copy link
Contributor

The code is MIT licensed. If an implementer only wants to keep the schema, they are free to use the Java class directly, provided they include the license.

We don't want to deal with the overhead of a separate module.

@Kehrlann Kehrlann self-assigned this Nov 18, 2025
@He-Pin
Copy link
Contributor Author

He-Pin commented Nov 18, 2025

But we already added a json module for this; this can help the kt and scala community too.

@Kehrlann
Copy link
Contributor

The reason we added json is to offer an extension point so that any JSON serialization library could be used with the SDK, and not just Jackson. See #453

It's not for consumption outside of MCP, rather for having a "json" SPI

@He-Pin
Copy link
Contributor Author

He-Pin commented Nov 18, 2025

There's also an advantage here: users can provide their own McpSchema implementation in a binary-compatible way, adding fields while reusing all the capabilities of the existing SDK. Currently, we cannot update the model independently when using mcp-core.

@Kehrlann, wdyt, this will enable users to iterate on the schema and implementation separately.

@Kehrlann
Copy link
Contributor

I don't think there is a lot of demand for this.

I'm going to close the PR, please open an issue instead. Please give detailed examples of what you're trying to achieve exactly. We'll see if the issue gains traction, and we'll sync about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants