fix: E11000 duplicate key error when creating timeout retry task #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a task times out and has
retryOnTimeoutCount > 0, theexpireTimedOutTasks()function creates a retry task by spreadingtask.toObject({ virtuals: false }). This includes the_idfield from the original task, causing MongoDB to throw anE11000 duplicate key errorwhen trying to insert the retry task.Solution
_idfield before creating the retry task, allowing MongoDB to generate a new_idretryOnTimeoutCountso retries are properly limited (without this, the retry task would have the same count and retry indefinitely)startedRunningAt,error,result, etc.) so the retry task starts freshChanges