Skip to content

Conversation

@Emma1-png
Copy link

Description

Added Fart sound effect for "sound > Play sound on click" category
I will need some help - this is my first pull for the repo - how would I give it sound (and also that it appears in the play sound on click menu)? The sound is in "frontend/static/sound/click16/fart-83471.mp3"

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Dec 15, 2025
@Emma1-png Emma1-png marked this pull request as draft December 15, 2025 13:36
@Emma1-png
Copy link
Author

The title is meant to be:
feat added fart sound

@Miodec
Copy link
Member

Miodec commented Dec 17, 2025

You still need to add 16 to the schemas as well as a button to the settings.html

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 17, 2025
Fix button tag for 'fart' option in settings.
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 18, 2025
@Emma1-png
Copy link
Author

Added the button to settings.html, but I can't find the correct file in the 'schemas' to add the sound effect, what is the correct file in "monkeytype/packages/schemas"? Thanks for your help in this

@fehmer
Copy link
Member

fehmer commented Dec 18, 2025

hi @Emma1-png .

the config is named playSoundOnClick:
image

If you search for it in packages/schemas you'll find
image
https://github.com/monkeytypegame/monkeytype/blob/master/packages/schemas/src/configs.ts#L129-L147

@fehmer fehmer changed the title Added fart sound effect feat: Add fart sound effect (@emma1-png) Dec 18, 2025
@monkeytypegeorge monkeytypegeorge added the packages Changes in local packages label Dec 18, 2025
@Emma1-png
Copy link
Author

Thanks @fehmer
I got it. I want to thank you from the very bottom of my heart

@Emma1-png Emma1-png marked this pull request as ready for review December 19, 2025 08:11
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 19, 2025
@Emma1-png Emma1-png changed the title feat: Add fart sound effect (@emma1-png) feat: Add fart sound effect (@EmmaQWE) Dec 19, 2025
@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Dec 19, 2025
@Emma1-png
Copy link
Author

@Miodec
How would I fix this ci-fe fail error?
Sorry again, github isn't really my strong suit.

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 19, 2025
@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff packages Changes in local packages waiting for update Pull requests or issues that require changes/comments before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants