Skip to content

Conversation

@KanishkKundu05
Copy link

@KanishkKundu05 KanishkKundu05 commented Dec 25, 2025

Migrate isolated components away from jQuery to use native DOM APIs and utilities, as part of the ongoing effort to reduce jQuery dependencies across the codebase.

Changes

Replaced jQuery method calls with native DOM equivalents in 8 isolated components:

  • elements/settings/account-settings-notice.ts
  • elements/version-button.ts
  • event-handlers/keymap.ts
  • event-handlers/login.ts
  • states/connection.ts
  • test/funbox/memory-funbox-timer.ts
  • test/out-of-focus.ts
  • test/pb-crown.ts

Implementation Details

  • Replaced jQuery selectors with getElementById(), querySelector(), querySelectorAll()
  • Replaced .on() with addEventListener() and manual event delegation using .closest()
  • Replaced jQuery utility methods with native equivalents

#7186

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff docs Related to Markdown files and documentation labels Dec 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted.

Details:

Title "refactor: migrate isolated components from jQuery to DOM utilities"
didn't match the configured pattern. Please ensure that the title
contains your name so that you can be credited in our changelog.

A correct version would look something like:

feat: add new feature (@github_username)
impr(quotes): add english quotes (@username)
fix(leaderboard): show user rank correctly (@user1, @user2, @user3)

@github-actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 25, 2025
@Leonabcd123
Copy link
Contributor

You're supposed to use the utils in ts/utils/dom instead of the native selectors.

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 25, 2025
@fehmer
Copy link
Member

fehmer commented Dec 25, 2025

Hi @KanishkKundu05 ,

thank you for your contribution. Like @Leonabcd123 already mentioned the goal of #7186 is to replace jQuery with our dom-utils. Please check the other PRs mentioned in the issue as reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Related to Markdown files and documentation frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants