Skip to content

Conversation

@badboy
Copy link
Member

@badboy badboy commented Dec 18, 2025

This has a new problem now though:
Not all metrics go through that and could be recorded in a different order.

Is that fine?
I think that's fine because:

  1. Same metric types are recorded on the dispatcher, so e.g. counting is always in correct order.
  2. Recording of a not-dispatched metric is always unrelated to any other metric, so the precise order doesn't matter either
  3. Ping methods are dispatched, so a call to a non-dispatched metric, followed by a dispatched ping submit keeps the correct order.

Note: things still go through the Glean Rust dispatcher, so things are ordered there in the way they come in.

This has a new problem now though:
Not all metrics go through that and could be recorded in a different order.

Is that fine?
I think that's fine because:
1. Same metric types are recorded on the dispatcher, so e.g. counting is
   always in correct order.
2. Recording of a not-dispatched metric is always unrelated to any other
   metric, so the precise order doesn't matter either
3. Ping methods _are_ dispatched, so a call to a non-dispatched metric,
   followed by a dispatched ping submit keeps the correct order.


Note: things _still_ go through the Glean Rust dispatcher, so things are
ordered there in the way they come in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants