Update Cmake #45
Open
Update Cmake #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoeter
reviewed
Nov 23, 2025
Owner
mpoeter
left a comment
mpoeter
left a comment
There was a problem hiding this comment.
Sorry for the late response and thank you for this PR - this is something I wanted to do for a long time but never found the time for it. However, I think it needs a bit more polishing.
Comment on lines
+156
to
160
| // carica la configurazione di base | ||
| _config = tao::config::from_file(opts.configfile); | ||
|
|
||
| // applica override dai parametri della riga di comando | ||
| for (const auto& param : opts.params) { |
Owner
There was a problem hiding this comment.
Please use English for writing comments.
Owner
There was a problem hiding this comment.
I think each subfolder should have its own CMakeLists file and in this file we just include the subfolders. This would make it cleaner and easier to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated CMake configuration following modern standards.
TODO: