Fpl basecase clean #49
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 77.65% 77.68% +0.02%
==========================================
Files 62 62
Lines 5813 6058 +245
Branches 889 1017 +128
==========================================
+ Hits 4514 4706 +192
- Misses 1104 1113 +9
- Partials 195 239 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean
branch
from
01d7dd8 to
450bb98
Compare
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean
branch
from
450bb98 to
eca951a
Compare
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean
branch
from
eca951a to
3d503f1
Compare
Improve the 4D base case of FPL:
* c/hv_priv.h: Remove x_aux from dlnote_t, x is const again.
* c/hv.c:
- Remove references to x_aux.
- Also maintain a list sorted according to z coordinate.
- Allocate (once) the auxiliar data structures used in the base case.
* c/hv4d_priv.h (onec4dplusU):
- Reconstruct the 3D base of the 4D contribution by sweeping the (sorted) z list.
- Use an auxiliar dlnode_t list (list_aux) and an auxiliar double vector (x_aux) for modified points.
- Take advantage of sweeping points in ascending order of the z-coordinate (continue_base_update_z_closest).
* c/hv.c: Use ->vol instead of ->x for the auxiliary vectors.
(fpli_hv4d): Delete unused.
* c/hv4d_priv.h (update_bound_3d): New.
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean
branch
2 times, most recently
from
ca7ffde to
9b33f37
Compare
MLopez-Ibanez
force-pushed
the
fpl-basecase-clean
branch
from
5a079e5 to
74063d7
Compare
MLopez-Ibanez
force-pushed
the
main
branch
3 times, most recently
from
02acf5d to
a85f6ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apguerreiro A version of fpl-basecase rebased over main and with a few minor improvements and updated docs.