-
Notifications
You must be signed in to change notification settings - Fork 951
Fix fastANI module #9583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix fastANI module #9583
Conversation
…le staging, added task.cpus to thread arg, created process stub, added optional tool outputs, and formatted input channels
vagkaratzas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valiant first effort, but will require some more updates.
| } | ||
| } | ||
|
|
||
| test("stub") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test with the new ql and rl functionality -- if files are missing from nf-core/test_datasets, push them
Co-authored-by: Evangelos Karatzas <32259775+vagkaratzas@users.noreply.github.com>
Co-authored-by: Evangelos Karatzas <32259775+vagkaratzas@users.noreply.github.com>
Co-authored-by: Evangelos Karatzas <32259775+vagkaratzas@users.noreply.github.com>
Co-authored-by: Evangelos Karatzas <32259775+vagkaratzas@users.noreply.github.com>
PR checklist
Fixes several issues with the fastANI module:
Replaced custom meta field for module flow control with standard meta.id fields and logic
Added
--threads $task.cpusto ensure proper multi-threadingMade output file names descriptive
Added stub block
Added optional outputs
This comment contains a description of changes (with reason).
If you've fixed a bug or added code that should be tested, add tests!
If you've added a new tool - have you followed the module conventions in the contribution docs
If necessary, include test data in your PR.
Remove all TODO statements.
Emit the
versions.ymlfile.Follow the naming conventions.
Follow the parameters requirements.
Follow the input/output options guidelines.
Add a resource
labelUse BioConda and BioContainers if possible to fulfil software requirements.
Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
nf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda