-
Notifications
You must be signed in to change notification settings - Fork 950
Add rgi/bwt #9585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vinisalazar
wants to merge
12
commits into
nf-core:master
Choose a base branch
from
vinisalazar:rgi/bwt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add rgi/bwt #9585
+408
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use template from rgi/main
- Use fastq pair instead of single fasta file
- add fastq extensions to 'pattern'
- Trying to pass linter
- build KMA/BWT index in workdir instead of program executable dir - update test snapshot
- Don't check temp/ directory on snapshot, is different every time - Update snapshot
- provide input.reads as list - don't check tsv snapshot (it's different every time)
- json files are in random order so snapshot differs every time (I think)
Contributor
Author
|
@nickp60 we might want to adjust the output channels a little bit, looks to me as though these are the main files: |
SPPearce
reviewed
Dec 23, 2025
SPPearce
reviewed
Dec 23, 2025
SPPearce
reviewed
Dec 23, 2025
Contributor
Author
|
@SPPearce thank you for the review, addressed your comments. |
- Use '--local' flag as default
|
@vinisalazar Thanks for doing all this! I agree with changing the output to specify those 5 outputs; that seems in line with the description in the docs |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
cc @nickp60