Skip to content

Conversation

@chaochaowong
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for if you don't provide SNVs?

Looks ok, but seems like candidate.sv.bcf.csi is unstable in the snapshots. Could you change it to just check the name? Probably this wasn't caught before because the timestamp in the VCF header is a date.

@chaochaowong
Copy link
Contributor Author

chaochaowong commented Dec 30, 2025

Is this for if you don't provide SNVs?

No. This change is for a test sample and config used in the pacvar pipeline (new release coming soon), where the sequencing coverage is low. If sawfish/discover runs with CNV enabled with low read coverage, it behaves similarly to hificnv and exits with status 65 due to insufficient coverage to determine CNV regions. Therefore, CNV must be disabled by setting ext.args = '--disable-cnv'.

When CNV is disabled, sawfish/discover does not produce several CNV-related outputs, including: copynum.bedgraph, copynum.mpack, sample.gcbias.mpack, and genome.gclevels.mpack. The emit option is already set to true for the first three files. I believe it is an oversight in the original module that genome.gclevels.mpack was not also marked as optional (emit: true), since it is likewise absent when CNV is disabled.

Looks ok, but seems like candidate.sv.bcf.csi is unstable in the snapshots. Could you change it to just check the name? Probably this wasn't caught before because the timestamp in the VCF header is a date.

Yes, I will edit main.nf.test so that it just check the name or file existance. [DONE]

Thank you so much for your feedback.

chaochaowong and others added 2 commits December 31, 2025 09:58
to test check the name of `candidate_sv_bcf_csi` instead of file existence.

Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
@SPPearce SPPearce added this pull request to the merge queue Jan 1, 2026
Merged via the queue into nf-core:master with commit 61cd0d3 Jan 1, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants