Skip to content

node-api: napi_set_prototype function #60711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 11 commits into from
Jan 2, 2026
Merged

node-api: napi_set_prototype function #60711

nodejs-github-bot merged 11 commits into from
Jan 2, 2026
+110 −27

Conversation

@siaeyy
Copy link
Contributor

@siaeyy siaeyy commented Nov 14, 2025

Almost same as napi_set_property
Refs: #60670

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 14, 2025

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Nov 14, 2025
addaleax
addaleax reviewed Nov 14, 2025
View reviewed changes
KevinEady
KevinEady reviewed Nov 14, 2025
View reviewed changes
@siaeyy siaeyy requested a review from KevinEady November 14, 2025 18:35
legendecas
legendecas reviewed Nov 18, 2025
View reviewed changes
@legendecas legendecas linked an issue Nov 25, 2025 that may be closed by this pull request
Add a direct API for setting object prototype in node_api.h #60670
Closed
@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project Nov 28, 2025
KevinEady
KevinEady suggested changes Nov 28, 2025
View reviewed changes
siaeyy added 3 commits December 2, 2025 14:11
@siaeyy
fix: wrong set_prototype prefix
dcc2192
@siaeyy
fix: use node_api_nogc_env instead of napi_env
94a2221 
Fix env parameter for some nogc finalizer functions
@siaeyy
test: schedule the finalizer for not running while gc
83a2e50 
Normally adding a finalizer that changes gc state, crash Node.js.
So we add a middle layer for not running the finalizer while gc.
@siaeyy siaeyy force-pushed the napi_set_prototype branch from 6cf78bb to 83a2e50 Compare December 2, 2025 11:32
@codecov
Copy link

codecov bot commented Dec 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (fc32ac2) to head (68b5a9e).
⚠️ Report is 273 commits behind head on main.

Files with missing lines Patch % Lines
src/js_native_api_v8.cc 54.54% 0 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60711      +/-   ##
==========================================
- Coverage   88.53%   88.53%   -0.01%     
==========================================
  Files         703      703              
  Lines      208222   208407     +185     
  Branches    40142    40195      +53     
==========================================
+ Hits       184357   184512     +155     
- Misses      15852    15895      +43     
+ Partials     8013     8000      -13
Files with missing lines Coverage Δ
src/js_native_api_v8.cc 76.49% <54.54%> (-0.08%) ⬇️

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70393/

@legendecas legendecas added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 5, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 6, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70402/

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 20, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 20, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70559/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 2, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70648/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 2, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70653/

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 2, 2026
@nodejs-github-bot nodejs-github-bot merged commit ae5cbda into nodejs:main Jan 2, 2026
78 of 79 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 2, 2026

Landed in ae5cbda

@github-project-automation github-project-automation bot moved this from In Progress to Done in Node-API Team Project Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments

@vmoroz vmoroz vmoroz approved these changes

@legendecas legendecas legendecas approved these changes

+1 more reviewer

@KevinEady KevinEady KevinEady requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

Node-API Team Project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a direct API for setting object prototype in node_api.h

7 participants

@siaeyy @nodejs-github-bot @addaleax @vmoroz @legendecas @KevinEady @avivkeller