Skip to content

node-api: use v-table to reverse module dependencies #60916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vmoroz wants to merge 2 commits into
base: main
Choose a base branch
from
+3,919 −1,217
Open

node-api: use v-table to reverse module dependencies #60916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3bd284
node-api: use v-table to reverse module dependencies
vmoroz Jan 7, 2026
fa88025
improve public API, add vtable-only test
vmoroz Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions node.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,8 +894,11 @@
'NODE_PLATFORM="<(OS)"',
'NODE_WANT_INTERNALS=1',
# Define NAPI_EXPERIMENTAL to enable Node-API experimental function symbols being exposed.
'NAPI_EXPERIMENTAL=1',
'NODE_API_EXPERIMENTAL_NO_WARNING=1',
'NAPI_EXPERIMENTAL',
# Suppress warning about using experimental Node-API features.
'NODE_API_EXPERIMENTAL_NO_WARNING',
# Enable Node-API headers to support v-table.
'NODE_API_RUNTIME_USE_VTABLE',
# Warn when using deprecated V8 APIs.
'V8_DEPRECATION_WARNINGS=1',
'NODE_OPENSSL_SYSTEM_CERT_PATH="<(openssl_system_ca_path)"',
Expand Down Expand Up @@ -1226,6 +1229,9 @@
'NODE_ARCH="<(target_arch)"',
'NODE_PLATFORM="<(OS)"',
'NODE_WANT_INTERNALS=1',
'NAPI_EXPERIMENTAL',
'NODE_API_EXPERIMENTAL_NO_WARNING',
'NODE_API_RUNTIME_USE_VTABLE',
],

'sources': [ '<@(node_cctest_sources)' ],
Expand Down
1,035 changes: 828 additions & 207 deletions src/js_native_api.h
View file
Open in desktop

Large diffs are not rendered by default.

595 changes: 585 additions & 10 deletions src/js_native_api_types.h
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading