Skip to content

Conversation

@joyeecheung
Copy link
Member

This helps diffing snapshots when the reproducibility gets broken.

This helps diffing snapshots when the reproducibility gets broken.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (4f24aff) to head (09ccbcf).
⚠️ Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61101      +/-   ##
==========================================
- Coverage   88.53%   88.51%   -0.02%     
==========================================
  Files         703      703              
  Lines      208546   208552       +6     
  Branches    40217    40221       +4     
==========================================
- Hits       184634   184601      -33     
- Misses      15926    15944      +18     
- Partials     7986     8007      +21     
Files with missing lines Coverage Δ
src/node.cc 75.96% <100.00%> (-0.08%) ⬇️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung
Copy link
Member Author

Removed the unused file and added back the helper (turns out it's still used to format stderr during failures).

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2025
@github-actions
Copy link
Contributor

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - src: dump snapshot source with node:generate_default_snapshot_source
   ⚠  - fixup! src: dump snapshot source with node:generate_default_snapshot_…
   ⚠  - fixup! fixup! src: dump snapshot source with node:generate_default_sn…
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20415476248

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 2, 2026
@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants