-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
doc: mention --newVersion release script #61255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
|
|
||
| to automate the remaining steps until step 6 or you can perform it manually | ||
| following the below steps. | ||
| following the below steps. For semver-minors, you can pass the new version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have a small nitpick on the phrasing to make it slightly more formal for the docs:
- following the below steps. For semver-minor releases, you can pass the new version explicitly using the
--newVersionargument:
Replacing 'arg' with 'argument' and 'semver-minors' with 'semver-minor releases' makes it read a bit smoother."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's bettter use this form:
following the steps below. For semver-minor releases, you can pass the new version explicitly using the --newVersion argument:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @NickNaso
| to automate the remaining steps until step 6 or you can perform it manually | ||
| following the below steps. | ||
| following the below steps. For semver-minors, you can pass the new version | ||
| explicitly with `--newVersion` arg: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| explicitly with `--newVersion` arg: | |
| explicitly with `--newVersion` flag: |
This is useful when preparing a semver-minor security release