Skip to content

test: add webidl web-platform tests #61316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
anonrig wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: add webidl web-platform tests #61316

anonrig wants to merge 3 commits into from
+2,637 −0

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jan 8, 2026

Adds webidl web-platform test suite.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 8, 2026

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 8, 2026
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2026
@anonrig anonrig requested review from jasnell and lemire January 8, 2026 15:44
@codecov
Copy link

codecov bot commented Jan 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.51%. Comparing base (842448b) to head (20b70bb).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61316      +/-   ##
==========================================
+ Coverage   88.00%   88.51%   +0.51%     
==========================================
  Files         704      704              
  Lines      208739   208739              
  Branches    40196    40276      +80     
==========================================
+ Hits       183706   184774    +1068     
+ Misses      16992    15978    -1014     
+ Partials     8041     7987      -54

see 101 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

KhafraDev
KhafraDev approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how many tests run with node's WPT runner?

@anonrig
Copy link
Member Author

anonrig commented Jan 8, 2026

Do you know how many tests run with node's WPT runner?

I'm not sure. I haven't checked.

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 8, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 8, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 8, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70731/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 9, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/70735/

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 9, 2026
@targos
Copy link
Member

targos commented Jan 9, 2026

Shouldn't there be a test-webidl.js file to actually run the tests?

legendecas
legendecas previously approved these changes Jan 9, 2026
View reviewed changes
@legendecas
Copy link
Member

legendecas commented Jan 9, 2026

Shouldn't there be a test-webidl.js file to actually run the tests?

Yes, added one locally and the following cases are failing:

ecmascript-binding/class-string-named-properties-object.window.js
ecmascript-binding/global-immutable-prototype.any.js
ecmascript-binding/global-mutable-prototype.any.js
ecmascript-binding/global-object-implicit-this-value.any.js
ecmascript-binding/legacy-factor-function-subclass.window.js
ecmascript-binding/observable-array-ownkeys.window.js
ecmascript-binding/observable-array-no-leak-of-internals.window.js
ecmascript-binding/legacy-factory-function-builtin-properties.window.js
ecmascript-binding/no-regexp-special-casing.any.js

@legendecas legendecas removed commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 9, 2026
@anonrig anonrig requested a review from legendecas January 9, 2026 21:27
legendecas
legendecas reviewed Jan 9, 2026
View reviewed changes
@anonrig anonrig force-pushed the yagiz/add-webidl-wpt branch from db5ace9 to f69d921 Compare January 9, 2026 21:36
@anonrig anonrig requested a review from legendecas January 9, 2026 21:36
anonrig
anonrig commented Jan 11, 2026
View reviewed changes
@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 11, 2026
@anonrig anonrig requested a review from mcollina January 11, 2026 01:44
MattiasBuelens
MattiasBuelens reviewed Jan 11, 2026
View reviewed changes
test/wpt/status/webidl.json
"ecmascript-binding/class-string-named-properties-object.window.js": {
"fail": {
"expected": [
"evaluation in WPTRunner.runJsTests()"
Copy link
Contributor

@MattiasBuelens MattiasBuelens Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a failing test, but rather like a problem with the test runner?

test/wpt/status/webidl.json
"Global object's operation throws when called on incompatible object",
"Global object's getter works when called on null / undefined",
"Global object's setter works when called on null / undefined",
"evaluation in WPTRunner.runJsTests()"
Copy link
Contributor

@MattiasBuelens MattiasBuelens Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happened here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattiasBuelens MattiasBuelens MattiasBuelens left review comments

@jazelly jazelly jazelly approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

@lemire lemire Awaiting requested review from lemire

@jasnell jasnell Awaiting requested review from jasnell

@legendecas legendecas Awaiting requested review from legendecas

@mcollina mcollina Awaiting requested review from mcollina

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anonrig @nodejs-github-bot @targos @legendecas @MattiasBuelens @jazelly @KhafraDev @avivkeller