use gradle wrapper and copy file path to the proper directory #2
Conversation
bhatti
left a comment
bhatti
left a comment
There was a problem hiding this comment.
Hi Liz, I would be happy to add any changes that can help in general but am trying to understand reason for these changes. Please reply back with why those changes were necessary and what specific problems were they causing?
| - run: curl -Ls https://github.com/nowsecure/auto-circleci-plugin/archive/1.2.1.tar.gz | tar -xzf - -C . | ||
| - run: | ||
| command: cd auto-circleci-plugin-1.2.0 && gradle run -Dauto.url=<< parameters.auto_url >> -Dauto.token=<< parameters.auto_token >> -Dauto.dir=<< parameters.auto_dir >> -Dauto.file=<< parameters.auto_file >> -Dauto.group=<< parameters.auto_group >> -Dauto.wait=<< parameters.auto_wait >> -Dauto.score=<< parameters.auto_score >> -Dauto.username=<<parameters.auto_username>> -Dauto.password=<<parameters.auto_password>> -Dauto.show.status.messages=<<parameters.auto_show_status_messages>> -Dauto.stop.tests.on.status=<<parameters.auto_stop_tests_on_status>> | ||
| command: cp << parameters.auto_file >> auto-circleci-plugin-1.2.1/<< parameters.auto_file >> |
There was a problem hiding this comment.
Can you explain why you need to copy auto_file as you should be able to use full path such as auto_file: /tmp/myworkspace/test.apk?
There was a problem hiding this comment.
Hi @bhatti Since the job is changing directories to auto-circleci-plugin-x.x.x, the file is not available at that path, even if I specify the path as stated above.
| command: cd auto-circleci-plugin-1.2.0 && gradle run -Dauto.url=<< parameters.auto_url >> -Dauto.token=<< parameters.auto_token >> -Dauto.dir=<< parameters.auto_dir >> -Dauto.file=<< parameters.auto_file >> -Dauto.group=<< parameters.auto_group >> -Dauto.wait=<< parameters.auto_wait >> -Dauto.score=<< parameters.auto_score >> -Dauto.username=<<parameters.auto_username>> -Dauto.password=<<parameters.auto_password>> -Dauto.show.status.messages=<<parameters.auto_show_status_messages>> -Dauto.stop.tests.on.status=<<parameters.auto_stop_tests_on_status>> | ||
| command: cp << parameters.auto_file >> auto-circleci-plugin-1.2.1/<< parameters.auto_file >> | ||
| - run: | ||
| command: cd auto-circleci-plugin-1.2.1 && ./gradlew run -Dauto.url=<< parameters.auto_url >> -Dauto.token=<< parameters.auto_token >> -Dauto.dir=<< parameters.auto_dir >> -Dauto.file=<< parameters.auto_file >> -Dauto.group=<< parameters.auto_group >> -Dauto.wait=<< parameters.auto_wait >> -Dauto.score=<< parameters.auto_score >> -Dauto.username=<<parameters.auto_username>> -Dauto.password=<<parameters.auto_password>> -Dauto.show.status.messages=<<parameters.auto_show_status_messages>> -Dauto.stop.tests.on.status=<<parameters.auto_stop_tests_on_status>> |
There was a problem hiding this comment.
I don't see any issue replacing gradle with ./gradlew but did you see any issues using gradle as it should be in the path of orb image.
There was a problem hiding this comment.
I found that it was not in the path of the orb image
|
Hi @bhatti I found that gradle was not available on the image in our jobs. In addition, the file was not available from the context where the job is running. These changes are meant to address both of those issues. |
|
Hi @lfalkner , these changes didn't work for our circle-ci projects and I asked Brian Lawrence who is communicating with Corey Emerson to provide your circle-ci configs. I can work with your configs and we can update these configs so that they are both backward compatible and works for you. |
2 participants
No description provided.