Skip to content

Conversation

@pianostringquartet
Copy link

I encountered some issues while following the readme. This PR fixes some typos/issues as well as expands some parts.

register-events and register-all are 1-arity

Re-frame-request register-events and register-all appear to be 1-arity functions, whereas README.md currently shows them as requires options:

Screen Shot 2020-10-04 at 7 27 40 PM

Screen Shot 2020-10-04 at 7 29 50 PM

I suggest using (register-events {}) and (register-all {}) instead, if you have no opts.

cljs-ajax: :json instead of (json-response-format)

The README.md uses :response-format (json-response-format), but this throws an error:

Screen Shot 2020-10-04 at 7 54 36 PM

I’ve found :response-format :json works instead.

(I’m using cljs-ajax/cljs-ajax {:mvn/version "0.8.1"}.)

unregistered event: :no-op

Screen Shot 2020-10-04 at 8 54 43 PM

Instead of using [:no-op], I define a real event handler for the on-failure case.

Expanded explanation of what it means to 'track the request in state'

I've provided explanations of the success and failure cases, along with what that looks like in state, using re-frame-10x's UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant