Update readme; fix typos, expands some sections; add screenshots of request in state #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some issues while following the readme. This PR fixes some typos/issues as well as expands some parts.
register-eventsandregister-allare 1-arityRe-frame-request
register-eventsandregister-allappear to be 1-arity functions, whereas README.md currently shows them as requires options:I suggest using
(register-events {})and(register-all {})instead, if you have no opts.cljs-ajax:
:jsoninstead of(json-response-format)The README.md uses
:response-format (json-response-format), but this throws an error:I’ve found
:response-format :jsonworks instead.(I’m using
cljs-ajax/cljs-ajax {:mvn/version "0.8.1"}.)unregistered event:
:no-opInstead of using
[:no-op], I define a real event handler for the on-failure case.Expanded explanation of what it means to 'track the request in state'
I've provided explanations of the success and failure cases, along with what that looks like in state, using re-frame-10x's UI.