Use std::unique_ptr in Span API fallback #1820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no reason why we shouldnt
ax3l
approved these changes
Dec 17, 2025
franzpoeschel
added a commit
to franzpoeschel/openPMD-api
that referenced
this pull request
Dec 17, 2025
* Use std::unique_ptr in Span API fallback no reason why we shouldnt * Remove unused string overloads * Remove support for boolean types
franzpoeschel
added a commit
to franzpoeschel/openPMD-api
that referenced
this pull request
Dec 17, 2025
* Use std::unique_ptr in Span API fallback no reason why we shouldnt * Remove unused string overloads * Remove support for boolean types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason why we should not.
unique_ptris less resource heavy thanstd::shared_ptr, and especially the ADIOS2 backend uses some optimizations based specifically onunique_ptr.Users may still provide
shared_ptr-based fallbacks,examples/12_span_write.cpptests this.Note: We still have some scattered untested instances of
std::stringandbooloverloads scattered here and there for dataset-related operations. With #1774, we are now more explicit about which overloads we instantiate. This led to having to remove some of these wrong instances now with this PR, especially from the Python API.