8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior

[mrserb]

Hi all,

This pull request contains a backport of commit 4abb5e4a from the openjdk/jdk repository.

The commit being backported was authored by Alex Henrie on 23 Jun 2016 and was reviewed by Kim Barrett and Max Ockner.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8157758 needs maintainer approval

Issue

• JDK-8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/682/head:pull/682
$ git checkout pull/682

Update a local copy of the PR:
$ git checkout pull/682
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/682/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 682

View PR using the GUI difftool:
$ git pr show -t 682

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/682.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8157758: JDK9 does not compile on Linux with GCC 6.1 because left-shifting a negative number has undefined behavior

Replace shifts of -1 with shifts of ~0u.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• fc9f057: 8285836: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java failed with "RuntimeException: Failed in server"
• aa9168c: 8364660: ClassVerifier::ends_in_athrow() should be removed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[openjdk]

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 04: Full - Incremental (a1cba8db)
• 03: Full - Incremental (8d74e557)
• 02: Full - Incremental (a3ad0073)
• 01: Full - Incremental (ba79b13c)
• 00: Full (a4ea7dfb)

[mrserb]

/approval request Clean backport. Fix for a broken build on macOS + XCode 16.4

[openjdk]

@mrserb
8157758: The approval request has been created successfully.

[mrserb]

The issue is similar to openjdk/jdk11u-dev#3042

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[mrserb]

/touch

[openjdk]

@mrserb The pull request is being re-evaluated and the inactivity timeout has been reset.

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@mrserb This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[mrserb]

/open

[openjdk]

@mrserb This pull request is now open

[jerboaa]

This one is needed to compile on newer MacOS X as well (and a stepping stone towards GHA on MacOSX using the MacOSX 15 runner).

[jerboaa]

Note that we don't have MacOSX GHA being run here as the old runners have been removed. Work is under way to re-instate those.

/approve yes

[openjdk]

@jerboaa
8157758: The approval request has been approved.