change identity matrix format to csr in cram #2771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewejohnson
approved these changes
Nov 21, 2023
Contributor
drewejohnson
left a comment
drewejohnson
left a comment
There was a problem hiding this comment.
Green means go! Thanks @eepeterson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Third time's the charm. For most of the discussion on this see PRs #2703 and #2764. We've lowered the bar - so help me God if CI doesn't pass...
Fixes # (issue)
Checklist
- [ ] I have run clang-format (version 15) on any C++ source files (if applicable)- [ ] I have made corresponding changes to the documentation (if applicable)- [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)