Modifications to deplete_with_transfer_rates regression test suite #2779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
paulromano
approved these changes
Nov 27, 2023
Contributor
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
@eepeterson Thanks for all the (painful) work to figure this one out!
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the
deplete_with_transfer_ratestest suite more robust, by settingCoupledOperator.round_number = True. This is done in thedeplete_with_transportregression tests to prevent simulations from diverging due to very tiny differences in atom number density. In addition, I tightened the tolerance on theassert_atoms_equalto be the same level of agreement (1e-6) as in thedeplete_with_transporttests. Previously the reaction rate assertion had a tighter tolerance than the atom number when it should probably be the inverse. I also changed the test particle and batch numbers to match the other tests as well at the same time. This change also allows PRs #2764 and #2703 to pass without changing the test suite (at least locally).Checklist
- [ ] I have run clang-format (version 15) on any C++ source files (if applicable)- [ ] I have made corresponding changes to the documentation (if applicable)- [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)