-
-
Notifications
You must be signed in to change notification settings - Fork 13
Uncap Pydantic Version #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pydantic dependency constraint in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
17-17: Consider adding an upper bound to prevent unexpected major version upgrades.Removing the version constraint entirely allows any future version of Pydantic to be installed, including potential v3 releases which could introduce breaking changes. While Pydantic does not intentionally make breaking changes in minor releases of V2 and all Pydantic versions above 1.0.0 are compatible with FastAPI, a constraint like
pydantic>=2,<3would protect against major version breaks while allowing flexibility within the v2.x series.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: python
- GitHub Check: compare-php
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
=======================================
Coverage ? 92.54%
=======================================
Files ? 51
Lines ? 1851
Branches ? 144
=======================================
Hits ? 1713
Misses ? 97
Partials ? 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I couldn't find the reason for the constraint to <2.7, local unit tests look fine with the newer version.
Summary by CodeRabbit
Chores
✏️ Tip: You can customize this high-level summary in your review settings.