Update garbage collection #717
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
deepsm007
force-pushed
the
DPTP-4340-promotion
branch
3 times, most recently
from
2f11fba to
cada9b8
Compare
| // will mirror Accepted releases to. | ||
| // For example: | ||
| // "alternateImageRepository": "quay.io/openshift-release-dev/dev-release" | ||
| // "alternateImageRepository": "quay.io/openshift/ci" |
There was a problem hiding this comment.
This is literally just a comment reference. If/when this goes live, you'll need to update all the respective references, like here: https://github.com/openshift/release/blob/6e2ede7d8f765e123cb1c0cfaf33f80a92a2b9e5/core-services/release-controller/_releases/release-ocp-4.21-ci.json#L10-L11
…nated deletion via remove__ prefixed tags in quay.io
deepsm007
force-pushed
the
DPTP-4340-promotion
branch
from
cada9b8 to
f05cd7d
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deepsm007 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@deepsm007: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| jobName := fmt.Sprintf("%s-remove-tag", payload.Name) | ||
| return c.ensureJob(jobName, nil, func() (*batchv1.Job, error) { | ||
| // Get cli image from mirror or config | ||
| cliImage := "registry.ci.openshift.org/ocp/4.16:cli" |
There was a problem hiding this comment.
- Don't like this being hard-coded
- If it must be hard-coded, then it should, at least, point to a more modern version (like:
4.21)
|
|
||
| job, prefix := newReleaseJobBase(jobName, cliImage, release.Config.AlternateImageRepositorySecretName) | ||
|
|
||
| rcPayloadTag := fmt.Sprintf("rc_payload__%s", payload.Name) |
There was a problem hiding this comment.
We currently do not create release tags named anything like: rc_payload__{version}, so this logic does not make any sense to me.
There was a problem hiding this comment.
I'm confused...
Based on this logic, the calculated "fromImage" will be something of the form: rc_payload__4.22.0-0.nightly-2025-12-17-101159
Which will be passed into oc mirror <FROM> <TO>, correct?
What I'm questioning is why you think the "FROM" image even exists with that naming convention?
AFAIK, the release-controller doesn't have any logic to create such a named release.
2 participants
Updates garbage collection for orphaned ReleasePayloads to use a coordinated deletion mechanism via remove__ prefixed tags, allowing the pruner to handle tag deletion. Update AlternateImageRepository example to reflect quay.io/openshift/ci as the default destination.
/cc @bradmwilliams
/hold