Skip to content

Fdp update edpm #3467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evallesp merged 1 commit into from
Jan 7, 2026
Merged

Fdp update edpm #3467

evallesp merged 1 commit into from
Jan 7, 2026
+1,080 −19

Conversation

@mnietoji
Copy link
Contributor

@mnietoji mnietoji commented Nov 7, 2025 •
edited
Loading

[multiple] Add fdp_update_edpm role for EDPM node updates

[fdp_update_edpm] Implement EDPM node update automation for FDP updates:

  • Role fdp_update_edpm: Updates EDPM nodes declaratively via Kubernetes CRs
    • Patches OpenStackDataPlaneNodeSet CRs with updated container images
    • Configures package updates via edpm_bootstrap_packages
    • Sets up registry authentication and CA certificates
    • Creates OpenStackDataPlaneDeployment to apply changes
    • Includes hypervisor firewall configuration for registry access
  • Fix hypervisor firewall configuration
    • Add delegate_to to execute iptables on correct hypervisor host
    • Previously executed on localhost instead of hypervisor
  • Integration in post-deployment.yml after control plane updates
  • Zuul CI configuration for automated testing

[fdp_update_container_images] Fix to properly update OpenStackVersion CR

  • Add set_fact task to build customContainerImages dict correctly

Assisted-By: Claude noreply@anthropic.com
Signed-off-by: Miguel Angel Nieto Jimenez mnietoji@redhat.com

@mnietoji mnietoji requested a review from a team as a code owner November 7, 2025 14:44
@mnietoji mnietoji closed this Nov 7, 2025
@mnietoji mnietoji reopened this Nov 7, 2025
@mnietoji mnietoji mentioned this pull request Nov 7, 2025
Closed
@mnietoji mnietoji force-pushed the fdp_update_edpm branch 3 times, most recently from b645ded to 02be96f Compare November 7, 2025 16:48
michburk
michburk previously requested changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@michburk michburk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this pr isn't split properly and also contains the changes from #3466

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 7, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/381a8462756e461fa40fdad368f58ea3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 44m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 14s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 53s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 27s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test TIMED_OUT in 30m 56s
❌ cifmw-pod-pre-commit FAILURE in 7m 51s
✔️ build-push-container-cifmw-client SUCCESS in 18m 58s
✔️ cifmw-molecule-fdp_update_container_images SUCCESS in 2m 18s
✔️ cifmw-molecule-fdp_update_edpm SUCCESS in 2m 22s

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 7, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8dae75330b79473b922c4f394be22509

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 38m 24s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 49s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 29s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 38s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 10s
❌ cifmw-pod-pre-commit FAILURE in 7m 49s
✔️ build-push-container-cifmw-client SUCCESS in 19m 15s
✔️ cifmw-molecule-fdp_update_container_images SUCCESS in 2m 19s
✔️ cifmw-molecule-fdp_update_edpm SUCCESS in 2m 17s

@mnietoji mnietoji force-pushed the fdp_update_edpm branch 2 times, most recently from d4a6725 to 6410812 Compare November 7, 2025 23:39
@mnietoji
Copy link
Contributor Author

mnietoji commented Nov 7, 2025

Looks like this pr isn't split properly and also contains the changes from #3466

This pr depends on the other one. When the other one is merged, i will rebase this one and I will only have one commit here

@mnietoji mnietoji force-pushed the fdp_update_edpm branch 2 times, most recently from f09d329 to 2f1a170 Compare November 7, 2025 23:52
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Nov 8, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a31750715d0943f7889539e20267c60d

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 33s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 26m 30s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 36s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 52s
❌ cifmw-pod-pre-commit FAILURE in 7m 58s
✔️ build-push-container-cifmw-client SUCCESS in 22m 17s
✔️ cifmw-molecule-fdp_update_container_images SUCCESS in 1m 44s
✔️ cifmw-molecule-fdp_update_edpm SUCCESS in 1m 52s

danpawlik
danpawlik reviewed Nov 12, 2025
View reviewed changes
danpawlik
danpawlik reviewed Nov 12, 2025
View reviewed changes
danpawlik
danpawlik reviewed Nov 12, 2025
View reviewed changes
danpawlik
danpawlik reviewed Nov 12, 2025
View reviewed changes
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 11, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d03970aa66cb4aa2b09e0d3a4c74d2e4

❌ openstack-k8s-operators-content-provider FAILURE in 5m 23s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 31s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 30s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 01s
✔️ build-push-container-cifmw-client SUCCESS in 18m 07s
✔️ cifmw-molecule-fdp_update_container_images SUCCESS in 2m 17s
✔️ cifmw-molecule-fdp_update_edpm SUCCESS in 2m 20s

@mnietoji mnietoji force-pushed the fdp_update_edpm branch 2 times, most recently from b0fbe03 to e75e75f Compare December 12, 2025 08:31
@mnietoji
Copy link
Contributor Author

mnietoji commented Dec 22, 2025

Please take a look what AI generates you back. Also some part of the code was already done in fdp_update_container_images.

Not same code, maybe name of the file is the same but it is doing it a different thing

@mnietoji mnietoji closed this Dec 22, 2025
@mnietoji mnietoji reopened this Dec 22, 2025
@mnietoji mnietoji force-pushed the fdp_update_edpm branch 2 times, most recently from 39a340c to 93e41a8 Compare December 22, 2025 10:24
@mnietoji
Copy link
Contributor Author

mnietoji commented Dec 22, 2025

Hi, have rebased the patch and gone through alll pending comments. Testing is green again

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

This PR is stale because it has been for over 15 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 7, 2026
@danpawlik
Copy link
Contributor

danpawlik commented Jan 7, 2026

blind approve.

danpawlik
danpawlik approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more less is ok. Blind approve.

@mnietoji
[multiple] Add fdp_update_edpm role for EDPM node updates
1b56d85 
[fdp_update_edpm] Implement EDPM node update automation for FDP updates:
- Role fdp_update_edpm: Updates EDPM nodes declaratively via Kubernetes CRs
  * Patches OpenStackDataPlaneNodeSet CRs with updated container images
  * Configures package updates via edpm_bootstrap_packages
  * Sets up registry authentication and CA certificates
  * Creates OpenStackDataPlaneDeployment to apply changes
  * Includes hypervisor firewall configuration for registry access
- Fix hypervisor firewall configuration
  * Add delegate_to to execute iptables on correct hypervisor host
  * Previously executed on localhost instead of hypervisor
- Integration in post-deployment.yml after control plane updates
- Zuul CI configuration for automated testing

[fdp_update_container_images] Fix to properly update OpenStackVersion CR
  * Add set_fact task to build customContainerImages dict correctly

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Miguel Angel Nieto Jimenez <mnietoji@redhat.com>
@evallesp evallesp enabled auto-merge (rebase) January 7, 2026 12:02
@evallesp evallesp merged commit 9ecdab2 into openstack-k8s-operators:main Jan 7, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danpawlik danpawlik danpawlik approved these changes

@evallesp evallesp evallesp approved these changes

@brjackma brjackma brjackma approved these changes

@michburk michburk Awaiting requested review from michburk

Assignees

No one assigned

Labels

Ready For Review Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mnietoji @amartyasinha @danpawlik @evallesp @brjackma @michburk