Enable CRD descriptions except 'core' #1758
Merged
+4,038
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, dprince The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This enables CRD descriptions for all openstack-operator CRDs except the *core* CRs including OpenStackControlplane and OpenStackVersion. The OpenStackControlplane CR is quite large with descriptions enabled and thus needs to stay disabled.
dprince
force-pushed
the
crd_descriptions
branch
from
d7b4a91 to
1e775c2
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
openshift-merge-bot
bot
merged commit 82fab3a
into
openstack-k8s-operators:main
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables CRD descriptions for all openstack-operator CRDs except the core CRs including OpenStackControlplane and OpenStackVersion. The OpenStackControlplane CR is quite large with descriptions enabled and thus needs to stay disabled.