Skip to content

Removed non-METATILE code as it no longer seems to work #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
hummeltech wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Removed non-METATILE code as it no longer seems to work #366

hummeltech wants to merge 1 commit into from

Conversation

@hummeltech
Copy link
Collaborator

@hummeltech hummeltech commented Jan 6, 2024 •
edited
Loading

I can't for the life of me figure out how to get it working without METATILE defined. There seem to be too many references to it which are not within an #ifdef directive block.

Also:

  • Removed hyphens/spaces from comments from meta-tile/meta-tiling/meta tile
    • In order to consolidate spellings

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 7, 2024
View reviewed changes
src/render_expired.c
gettimeofday(&end, NULL);
printf("\nTotal for all tiles rendered\n");
printf("Meta tiles rendered: ");
printf("Metatiles rendered: ");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/printf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
src/render_expired.c
printf("Total tiles expanded from input: %d\n", num_all);
printf("Total meta tiles deleted: %d\n", num_unlink);
printf("Total meta tiles touched: %d\n", num_touch);
printf("Total metatiles deleted: %d\n", num_unlink);

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/printf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
src/render_expired.c
printf("Total meta tiles deleted: %d\n", num_unlink);
printf("Total meta tiles touched: %d\n", num_touch);
printf("Total metatiles deleted: %d\n", num_unlink);
printf("Total metatiles touched: %d\n", num_touch);

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/printf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
src/render_old.c
gettimeofday(&end, NULL);
printf("\nTotal for all tiles rendered\n");
printf("Meta tiles rendered: ");
printf("Metatiles rendered: ");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/printf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
src/render_list.c
gettimeofday(&end, NULL);
printf("\n");
printf("Meta tiles rendered: ");
printf("Metatiles rendered: ");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/printf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
src/render_list.c
printf("*****************************************************\n");
printf("Total for all tiles rendered\n");
printf("Meta tiles rendered: ");
printf("Metatiles rendered: ");

Check notice

Code scanning / Flawfinder

If format strings can be influenced by an attacker, they can be exploited (CWE-134).

format/printf:If format strings can be influenced by an attacker, they can be exploited (CWE-134).
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.56%. Comparing base (19facb0) to head (d4e12ed).
⚠️ Report is 70 commits behind head on master.

Files with missing lines Patch % Lines
src/render_list.c 50.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   71.90%   71.56%   -0.34%     
==========================================
  Files          23       23              
  Lines        5527     5525       -2     
==========================================
- Hits         3974     3954      -20     
- Misses       1553     1571      +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hummeltech hummeltech force-pushed the RemoveMetatileCode branch 2 times, most recently from 1fd7bc8 to 01eee59 Compare January 12, 2024 04:19
@hummeltech
Removed non-METATILE code as it no longer seems to work
d4e12ed 
Remove unused reference to METATILEFALLBACK
Rewrote `meta tile`/`meta-tile` to `metatile`
@hummeltech hummeltech marked this pull request as draft June 22, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hummeltech @codecov-commenter