Work In Progress - Replace QtCharts with LGPL compliant JKQtPlotter #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macumber
commented
Sep 2, 2025
CMakeLists.txt
Outdated
| GIT_REPOSITORY https://github.com/jkriege2/JKQtPlotter.git | ||
| GIT_TAG v4.0.3) | ||
|
|
||
| FetchContent_MakeAvailable(JKQTPlotter) |
Collaborator
Author
There was a problem hiding this comment.
@jmarrec we could make a custom conan recipe for this dependency if that is better, but I don't know how to do that
Collaborator
There was a problem hiding this comment.
macumber
commented
Sep 2, 2025
src/openstudio_app/CMakeLists.txt
Outdated
| elseif( UNIX ) | ||
|
|
||
| foreach(LIB ${QT_LIBS} ${QT_WEB_LIBS}) | ||
| foreach(LIB ${QT_LIBS} ${QT_WEB_LIBS} ${JKQT_LIBS}) |
Collaborator
Author
There was a problem hiding this comment.
@jmarrec this is not working on Unix but I'm not sure why
Collaborator
There was a problem hiding this comment.
This isn't even built when you are configuring (_deps/jkqtplotter6-build/output/ is empty).
Also, I don't think we want to be doing this anyways.
We should link to the JKQTPlotter::JKQTPlotter target.
And I think it handles qtdeploy... Or we should just build it statically.
Collaborator
Author
|
Seem to be hitting jkriege2/JKQtPlotter#80 on Mac at least |
jmarrec
force-pushed
the
836_JKQTPlotter
branch
from
c07664c to
bd6af44
Compare
jmarrec
force-pushed
the
836_JKQTPlotter
branch
from
e78a4c7 to
dd4a482
Compare
Collaborator
Author
|
I'm good to abandon this for now if you want @jmarrec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #836