Spike: Display identity deposit amount when creating/updating subnet identity (#344) [WIP] #753
+315
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Comment on lines
+102
to
+109
| constant_names = [ | ||
| "SubnetIdentityDeposit", | ||
| "IdentityDeposit", | ||
| "SubnetIdentityFee", | ||
| "IdentityFee", | ||
| "SubnetIdentityDepositAmount", | ||
| "IdentityDepositAmount", | ||
| ] |
Contributor
There was a problem hiding this comment.
Where do these come from?
SmartDever02
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays the exact deposit required when creating or updating subnet identity.
Changes
get_identity_deposit()to query identity deposit constants from chainregister_network_with_identity: Now displays deposit amount when creating subnet with identity (deposit is NOT forgone - still required)set_subnet_identity: Shows deposit amount in confirmation prompt when updating identityprint()instead of Rich Console)Answer to Issue Question
Q: When creating a subnet with identity via
register_network_with_identity, is the deposit forgone?A: No, the deposit is still required. This PR now displays the deposit amount to users before they proceed, making it clear that a deposit is needed even when creating a subnet with identity in a single transaction.
Findings
Testing
✅ Unit tests pass (6/6)
✅ E2E tests pass
✅ JSON output is clean and parseable