Fix stale bounds in SymbolicOptimizations by clearing SkipInvalidation before SimplifyShapeOfSubGraph #33288
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evkotov
added
the
category: transformations
github-actions
bot
added
category: Core
praasz
requested changes
Dec 18, 2025
| /// \brief Unconditionally unsets bound value descriptions, ignoring SkipInvalidation flag. | ||
| /// \note Use this method when graph structure changes (e.g., after replace_source_output) | ||
| /// to ensure bounds are properly recalculated even when SkipInvalidation is set. | ||
| void force_invalidate_values(); |
Contributor
There was a problem hiding this comment.
The new public member should not be introduced.
It would be better to fix SkipInvalidation flag propagation , to remove it from nodes where bound has to be re-calculated
praasz
requested changes
Dec 18, 2025
| // Since we modified the Concat inputs, bounds must be recalculated. | ||
| // Use force_invalidate_values() to ignore SkipInvalidation flag that may be set | ||
| // by SymbolicPropagation, ensuring bounds are properly recalculated. | ||
| concat->force_invalidate_values(); |
Contributor
There was a problem hiding this comment.
As there function which can add this flag we can have dev API helper to remove it will also single line call.
Or maybe during propagation of this flag it should be not set here at all
github-actions
bot
removed
category: Core
evkotov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR fixes an issue where VIT tests fail in optimum-intel due to stale bounds in Concat node after AbsSinking transformation.
Problem
When SymbolicOptimizations runs with full_run=true:
The root cause is that remove_skip_invalidation_rti() was called at the end of SymbolicOptimizations::run_on_model(), after SimplifyShapeOfSubGraph had already run with stale bounds.
Solution
Add ClearSkipInvalidation pass that calls remove_skip_invalidation_rti() before SimplifyShapeOfSubGraph. This removes SkipInvalidation flags and recalculates all bounds, ensuring that transformations like AbsSinking work with fresh data.
Changes
Tickets: