add select.select. We can always return for now, because we only support blocking File I/O

Author: timfel

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/SelectModuleBuiltins.java

@@ -40,18 +40,36 @@
  */
 package com.oracle.graal.python.builtins.modules;
 
-import java.util.ArrayList;
+import java.io.PrintStream;
 import java.util.List;
 
+import com.oracle.graal.python.builtins.Builtin;
 import com.oracle.graal.python.builtins.CoreFunctions;
 import com.oracle.graal.python.builtins.PythonBuiltins;
+import com.oracle.graal.python.builtins.objects.tuple.PTuple;
 import com.oracle.graal.python.nodes.function.PythonBuiltinBaseNode;
+import com.oracle.graal.python.nodes.function.PythonBuiltinNode;
+import com.oracle.graal.python.runtime.PythonOptions;
+import com.oracle.truffle.api.dsl.GenerateNodeFactory;
 import com.oracle.truffle.api.dsl.NodeFactory;
+import com.oracle.truffle.api.dsl.Specialization;
 
 @CoreFunctions(defineModule = "select")
 public class SelectModuleBuiltins extends PythonBuiltins {
     @Override
     protected List<? extends NodeFactory<? extends PythonBuiltinBaseNode>> getNodeFactories() {
-        return new ArrayList<>();
+        return SelectModuleBuiltinsFactory.getFactories();
+    }
+
+    @Builtin(name = "select", fixedNumOfPositionalArgs = 3, parameterNames = {"rlist", "wlist", "xlist"}, keywordArguments = {"timeout"})
+    @GenerateNodeFactory
+    static abstract class SelectNode extends PythonBuiltinNode {
+        @Specialization
+        PTuple select(Object rlist, Object wlist, Object xlist, @SuppressWarnings("unused") Object timeout) {
+            if (PythonOptions.getFlag(getContext(), PythonOptions.VerboseFlag)) {
+                new PrintStream(getContext().getEnv().err()).println("select() will always return immediately, we only support blocking I/O for now");
+            }
+            return factory().createTuple(new Object[]{rlist, wlist, xlist});
+        }
     }
 }

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/builtins/objects/function/AbstractFunctionBuiltins.java

@@ -305,6 +305,9 @@ private static Object getSignature(boolean enclosingType, Arity arity) {
             boolean takesVarArgs = arity.takesVarArgs();
             boolean takesVarKeywordArgs = arity.takesVarKeywordArgs();
 
+            String[] parameterIds = arity.getParameterIds();
+            int paramIdx = 0;
+
             StringBuilder sb = new StringBuilder();
             char argName = 'a';
             sb.append('(');
@@ -315,7 +318,11 @@ private static Object getSignature(boolean enclosingType, Arity arity) {
                     sb.append("self");
                 }
                 for (int i = 1; i < minArgs; i++) {
-                    sb.append(", ").append(argName++);
+                    if (paramIdx >= parameterIds.length) {
+                        sb.append(", ").append(argName++);
+                    } else {
+                        sb.append(", ").append(parameterIds[paramIdx++]);
+                    }
                 }
             }
             if (minArgs > 0) {

graalpython/com.oracle.graal.python/src/com/oracle/graal/python/runtime/PythonOptions.java

@@ -133,6 +133,14 @@ public static int getIntOption(PythonContext context, OptionKey<Integer> key) {
         return context.getOptions().get(key);
     }
 
+    @TruffleBoundary
+    public static boolean getFlag(PythonContext context, OptionKey<Boolean> key) {
+        if (context == null) {
+            return key.getDefaultValue();
+        }
+        return context.getOptions().get(key);
+    }
+
     public static int getCallSiteInlineCacheMaxDepth() {
         return getOption(PythonLanguage.getContextRef().get(), CallSiteInlineCacheMaxDepth);
     }

graalpython/lib-graalpython/__builtins_patches__.py

@@ -74,11 +74,6 @@ def open(*args, **kwargs):
 setattr(builtins, 'open', open)
 
 
-
-
-# platform
-sys.modules["select"].select = lambda *args: print("select", args)
-
 # in setuptools' pkg_resources/__init__.py
 sys.modules["zipimport"] = type(sys)("zipimport")
 sys.modules["zipimport"].zipimporter = None