support endpoints alongside endpoint #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-mgo
force-pushed
the
support_endpoints
branch
2 times, most recently
from
7eaeeae to
a6ec61d
Compare
jobs62
approved these changes
Nov 26, 2025
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
jobs62
force-pushed
the
support_endpoints
branch
from
ba60e8b to
328021c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this: https://github.com/outscale/osc-config-spec
endpoint was supported by osc-cli instead of endpoints as specify by the standard.
So this PR add support for endpoints.
Instead of patching osc-cli in order to store all endpoints in the configuration,
we use the
servicepass in parameter to change the endpoint internal variable.