Skip to content

[TECHNICAL] Increase rating dialog delay #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jesmrec merged 3 commits into from
Dec 23, 2025
Merged

[TECHNICAL] Increase rating dialog delay #4744

jesmrec merged 3 commits into from
Dec 23, 2025
+15 −2

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Dec 22, 2025 •
edited
Loading

Related Issues

App: -

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Dec 22, 2025
@joragua joragua added this to the 4.8 - Current milestone Dec 22, 2025
@joragua joragua marked this pull request as ready for review December 23, 2025 09:57
@joragua joragua requested a review from jesmrec December 23, 2025 09:57
jesmrec
jesmrec approved these changes Dec 23, 2025
View reviewed changes
Copy link
Collaborator

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Moving to QA

@jesmrec jesmrec closed this Dec 23, 2025
@jesmrec jesmrec reopened this Dec 23, 2025
@jesmrec
Copy link
Collaborator

jesmrec commented Dec 23, 2025

Basic checks. Feature worked, just adjusting values. If CI ✅ , moving forward.

@jesmrec jesmrec merged commit 834cab8 into master Dec 23, 2025
14 checks passed
@jesmrec jesmrec deleted the technical/increase_rating_dialog_delay branch December 23, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa Estimation - 1 (XS) Technical

Projects

None yet

Milestone

4.8 - Current

Development

Successfully merging this pull request may close these issues.

4 participants

@joragua @jesmrec @ownclouders