Allow reading persistent component slot via mgs #2332
+83
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
approved these changes
Jan 5, 2026
Contributor
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
LGTM (other than needing to point Cargo.toml back to main once the MGS PR is merged)
labbott
reviewed
Jan 5, 2026
| Ok(HfPersistentData { dev_select }) => { | ||
| Ok(Self::dev_to_slot(dev_select)) | ||
| } | ||
| Err(HfError::NoPersistentData) => Ok(0), |
Collaborator
There was a problem hiding this comment.
Maybe a comment explaining why it's okay to fall back to slot 0?
Contributor
Author
There was a problem hiding this comment.
Added a comment but maybe it's worth just passing through the error so we don't mask failures to set a persistent slot?
Collaborator
There was a problem hiding this comment.
returning the error would be my preference, I had assumed this was needed for some automatic testing or edge case where 0 made sense
luqmana
force-pushed
the
get-persistent-slot
branch
from
9af440e to
0ce0264
Compare
labbott
approved these changes
Jan 6, 2026
Collaborator
labbott
left a comment
labbott
left a comment
There was a problem hiding this comment.
LGTM thanks for doing this work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with oxidecomputer/management-gateway-service#476 fixes #2331.