-
Notifications
You must be signed in to change notification settings - Fork 34
feat(ConversationHistoryNav): added search actions #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://chatbot-pr-chatbot-774.surge.sh A11y report: https://chatbot-pr-chatbot-774-a11y.surge.sh |
rebeccaalpert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also want to check to see how the additional items work in a resizable toolbar/different breakpoints, etc. if we are not completely offloading toolbar creation to the end user.
packages/module/src/ChatbotConversationHistoryNav/ChatbotConversationHistoryNav.tsx
Show resolved
Hide resolved
packages/module/src/ChatbotConversationHistoryNav/ChatbotConversationHistoryNav.tsx
Outdated
Show resolved
Hide resolved
c4a23e2 to
ab3fb3c
Compare
|
|
||
| ### Drawer with search actions | ||
|
|
||
| The conversation history drawer supports additional customization through `searchActionStart` and `searchActionEnd` props, which allow you to add controls before and after the search input field. These props are useful for adding filtering, sorting, or other search-related functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The conversation history drawer supports additional customization through `searchActionStart` and `searchActionEnd` props, which allow you to add controls before and after the search input field. These props are useful for adding filtering, sorting, or other search-related functionality. | |
| You can customize the search experience within the conversation history drawer via the `searchActionStart` and `searchActionEnd` props, which provide additional search controls before and after the input field. These props are useful for adding filtering, sorting, or other search-related functionality. |
a small tweak - otherwise I like what you have!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is done
edonehoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fabulous to me 👍
rebeccaalpert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine by me - you probably just want to make sure the yarn.lock file gets dropped. Up to you and Nicole if you want to allow the semi-custom toolbar approach as well as the custom one!
nicolethoen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why the package-lock.json and yarn.lock files are updated here?
Do you want to double check those updates are both necessary?
85ef6a2 to
bde4d90
Compare
So the way it's currently built out, a consumer can really add in whatever action they want at start/end. The example was sort of just a couple of potential actions that might be used (or int he case of the sort action, one that was mentioned in the original issue). That's really the only reason I kept the verbiage a bit vague for the example, since it could be anything.
Not really - it logs something in the console is all. Mainly just wanted to show the sort action a bit more in depth with a Select menu upon clicking it.
We could, though it would be more custom styling in the example since any Button variant could be rendered there by the consumer (or potentially anything could be rendered there, really). |
|
🎉 This PR is included in version 6.5.0-prerelease.26 🎉 The release is available on: Your semantic-release bot 📦🚀 |

Closes #768