Skip to content

Conversation

@ylebre
Copy link
Member

@ylebre ylebre commented Jun 2, 2025

This lets phpunit run using the docker images from 'main' instead of the PR branch 179.

Fixes #196

@Potherca Potherca force-pushed the fix/docker-php-unit-path branch from fb27ae8 to 8ad9201 Compare June 2, 2025 14:44
@Potherca
Copy link
Member

Potherca commented Jun 2, 2025

To allow the GitHub Action (GHA) to build/push docker images to a fork, the hard-codded pdsinterop/solid-nextcloud has been replaced with the github.repository context variable in the relevant GHAs.

These changes can be seen working on my fork: https://github.com/potherca-contrib/solid-nextcloud

Steps taken:

  1. Merge the MR
  2. Wait for GHA to run
  3. Check that Docker images have been created fromthe merged MR
  4. Re-run the failed PHPUnit GHA.

After that, all checks are green: https://github.com/potherca-contrib/solid-nextcloud/actions/runs/15396265579

@ylebre ylebre merged commit 368e4c8 into main Jun 3, 2025
20 of 35 checks passed
@ylebre ylebre deleted the fix/docker-php-unit-path branch June 3, 2025 19:18
@Potherca Potherca added this to the v0.10.0 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update hardcoded container version to use main

3 participants