-
Notifications
You must be signed in to change notification settings - Fork 11
handle token request cases for authorization_code and refresh_token differently #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The refresh token that is generated is actually an encoded json object, containing something like this: |
Potherca
reviewed
Jun 23, 2025
Member
Author
|
Ok - it turned out the configuration passed to the oauth server was missing the client ID because it was in the POST instead of in the GET. After changing that around, it looks to be working now. |
Potherca
approved these changes
Jun 26, 2025
Member
|
I've added the PHP Codesniffer config as discussed in the comments. |
Feature/user backend
Potherca
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix #204
Work so far:
The current result is that the 500 error is solved, but replaced with a 401 instead. This one is coming from deeper in the token handling.