Update cookies docker hash #211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into the logs of the
solid-tests-suites.ymlrun, I noticed thatmichielbdejong/nextcloud-cookiewas pulled twice. The cause was a combination of two things.The first is that
run-solid-test-suite.shdoes a docker pull ofmichielbdejong/nextcloud-cookiewithout specifying a version. This defaults tolatest.The second is that the hash in
COOKIE_TAGwas not updated to the newer image.This MR updates the hash to the newer image and changes the script to also use a hash, to resolve both issues.
This reduces the "Start Docker Containers" job from an average of 1 minute 20 to an average of 50 seconds, saving an average of 30 seconds of CI runtime.