Small code improvements #216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…one PHP Solid Server.
Potherca
force-pushed
the
fix/CLN-012-access-token-steal
branch
from
d373af7 to
5941e5b
Compare
Potherca
force-pushed
the
fix/CLN-012-access-token-steal
branch
from
5941e5b to
13a4ec4
Compare
Member
Author
|
Superseded by #217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR makes some changes to improve the quality of the
ServerController.php.This in preparation of the fix for CLN-012 and for closer alignment with multiuser-php-solid-server SolidIdp code.
The MR also fixes an issue with the GitHub Action (GHA) not running the unit-tests correctly.